[
https://issues.apache.org/jira/browse/FLINK-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500040#comment-16500040
]
ASF GitHub Bot commented on FLINK-9398:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6049#discussion_r192697261
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/ListOptions.java ---
@@ -28,20 +29,26 @@
*/
public class ListOptions extends CommandLineOptions {
- private final boolean running;
- private final boolean scheduled;
+ private final boolean showRunning;
+ private final boolean showScheduled;
+ private final boolean showAll;
public ListOptions(CommandLine line) {
super(line);
- this.running = line.hasOption(RUNNING_OPTION.getOpt());
- this.scheduled = line.hasOption(SCHEDULED_OPTION.getOpt());
+ this.showAll = line.hasOption(ALL_OPTION.getOpt());
+ this.showRunning = line.hasOption(RUNNING_OPTION.getOpt()) ||
this.showAll;
+ this.showScheduled = line.hasOption(SCHEDULED_OPTION.getOpt())
|| this.showAll;
--- End diff --
I would prefer this class being a dumb getter and having the OR logic in
CLIFrontend.
This class is just a representation of what was configured, and I would
leave the interpretation up to the using classes.
> Flink CLI list running job returns all jobs except in CREATE state
> ------------------------------------------------------------------
>
> Key: FLINK-9398
> URL: https://issues.apache.org/jira/browse/FLINK-9398
> Project: Flink
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
>
> See:
> https://github.com/apache/flink/blob/4922ced71a307a26b9f5070b41f72fd5d93b0ac8/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L437-L445
> Seems like CLI command: *flink list -r* returns all jobs except jobs in
> *CREATE* state. which conflicts with the CLI description: *Running/Restarting
> Jobs*.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
