[
https://issues.apache.org/jira/browse/FLINK-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500196#comment-16500196
]
ASF GitHub Bot commented on FLINK-9410:
---------------------------------------
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/6087#discussion_r192736809
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -406,6 +407,43 @@ public void onError(Throwable error) {
onFatalError(error);
}
+ @Override
+ public void onContainerStarted(ContainerId containerId, Map<String,
ByteBuffer> allServiceResponse) {
+ log.info("The container {} started.", containerId);
+ }
+
+ @Override
+ public void onContainerStatusReceived(ContainerId containerId,
ContainerStatus containerStatus) {
+ }
+
+ @Override
+ public void onContainerStopped(ContainerId containerId) {
+ log.info("The container {} is stopped.", containerId);
+ }
+
+ @Override
+ public void onStartContainerError(ContainerId containerId, Throwable t)
{
+ log.error("Could not start TaskManager in container {}.",
containerId, t);
+
+ // release the failed container
+ YarnWorkerNode yarnWorkerNode = workerNodeMap.remove(new
ResourceID(containerId.toString()));
+ resourceManagerClient.releaseAssignedContainer(containerId);
+ // ask for a new one
+
requestYarnContainer(yarnWorkerNode.getContainer().getResource(),
yarnWorkerNode.getContainer().getPriority());
+ }
+
+ @Override
+ public void onGetContainerStatusError(ContainerId containerId,
Throwable t) {
+ log.error("Error occurred during get the container {} status.",
containerId, t);
+ onFatalError(t);
+ }
+
+ @Override
+ public void onStopContainerError(ContainerId containerId, Throwable t) {
+ log.error("Error occurred during stop the container {}.",
containerId, t);
+ onFatalError(t);
--- End diff --
change.
> Replace NMClient with NMClientAsync in YarnResourceManager
> ----------------------------------------------------------
>
> Key: FLINK-9410
> URL: https://issues.apache.org/jira/browse/FLINK-9410
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Till Rohrmann
> Assignee: mingleizhang
> Priority: Critical
> Fix For: 1.6.0
>
>
> Currently, the {{YarnResourceManager}} uses the synchronous {{NMClient}}
> which is called from within the main thread of the {{ResourceManager}}. Since
> these operations are blocking, we should replace the client with the
> {{NMClientAsync}} and make the calls non blocking.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
