GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6119
[FLINK-9458] Ignore SharedSlot in CoLocationConstraint when not using
legacy mode
## What is the purpose of the change
The SharedSlot in CoLocationConstraint is only set when using the legacy
mode. Thus,
CoLocationConstraint#isAssignedAlive should only check the SharedSlot if it
was
previously set. This fixes the NPE when restarting a job with a co-location
constraint
when using the new mode.
## Verifying this change
- Added `ExecutionGraphCoLocationRestartTest#testConstraintsAfterRestart`
which verifies that an `ExecutionGraph` with co-location constraints can be
restarted with the legacy as well as the new mode.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
fixCoLocationConstraintRecovery
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6119
----
commit acf70e8cca10caa2fe0cd8d5e95885b39ed0b187
Author: Till Rohrmann <trohrmann@...>
Date: 2018-06-05T07:12:49Z
[FLINK-9458] Ignore SharedSlot in CoLocationConstraint when not using
legacy mode
The SharedSlot in CoLocationConstraint is only set when using the legacy
mode. Thus,
CoLocationConstraint#isAssignedAlive should only check the SharedSlot if it
was
previously set. This fixes the NPE when restarting a job with a co-location
constraint
when using the new mode.
----
---
