[ 
https://issues.apache.org/jira/browse/FLINK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503232#comment-16503232
 ] 

ASF GitHub Bot commented on FLINK-9451:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6089#discussion_r193394392
  
    --- Diff: flink-end-to-end-tests/flink-quickstart-test/pom.xml ---
    @@ -0,0 +1,98 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +   <parent>
    +           <groupId>org.apache.flink</groupId>
    +           <artifactId>flink-end-to-end-tests</artifactId>
    +           <version>1.6-SNAPSHOT</version>
    +   </parent>
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <artifactId>flink-quickstart-test</artifactId>
    +   <name>flink-quickstart-test</name>
    +   <packaging>jar</packaging>
    +
    +   <properties>
    +           <scala.binary.version>2.11</scala.binary.version>
    +   </properties>
    +
    +   <dependencies>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>provided</scope>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-streaming-scala_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-connector-elasticsearch5_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +   </dependencies>
    +
    +   <build>
    --- End diff --
    
    This section should be unnecessary.


> End-to-end test: Scala Quickstarts
> ----------------------------------
>
>                 Key: FLINK-9451
>                 URL: https://issues.apache.org/jira/browse/FLINK-9451
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Quickstarts
>    Affects Versions: 1.5.0, 1.4.1, 1.4.2
>            Reporter: Yazdan Shirvany
>            Assignee: Yazdan Shirvany
>            Priority: Blocker
>
> We could add an end-to-end test which verifies Flink's quickstarts scala. It 
> should do the following:
>  # create a new Flink project using the quickstarts archetype
>  # add a new Flink dependency to the {{pom.xml}} (e.g. Flink connector or 
> library)
>  # run {{mvn clean package -Pbuild-jar}}
>  # verify that no core dependencies are contained in the jar file
>  # Run the program



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to