Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6129#discussion_r193701993
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java
---
@@ -117,7 +107,9 @@ public boolean filter(Long value) throws Exception {
}
}).withBroadcastSet(solution, "SOLUTION")).output(new
DiscardingOutputFormat<Long>());
env.execute();
- expected = testString; // this will be a useless verification
now.
+ String expected = testString; // this will be a useless
verification now.
+
+ compareResultsByLinesInMemory(expected, resultPath);
--- End diff --
this is unnecessary and can be removed as the actual check is done in the
function.
---