Github user medcv commented on the issue:

    https://github.com/apache/flink/pull/6136
  
    @kisimple Recently I started to work on same example. I ran your code on my 
local and it did work perfectly. I could see some checkstyle errors that I 
think travis might pick them up. 
    
    I have a suggestion for the sake of example scenario. 
    For the `alerts` event you using `LocalTime` which indicate when `alerts` 
occurred, it would be useful also add `warnings` timestamp to `alerts` event in 
order to show when racks temperature passed the threshold, something like this 
on 
[line](https://github.com/kisimple/flink/blob/5cd3a374b84b2a7aaedb4c4184caded073e19295/flink-examples/flink-examples-cep/src/main/java/org/apache/flink/cep/examples/java/monitoring/TemperatureMonitoring.java#L133)
     
    `out.collect(new TemperatureAlert(first.getRackID(), second.getDatetime()));
    `
    
    of course it needs to update the `TemperatureAlert` model also.


---

Reply via email to