[
https://issues.apache.org/jira/browse/FLINK-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505598#comment-16505598
]
ASF GitHub Bot commented on FLINK-4303:
---------------------------------------
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6136
@kisimple Recently I started to work on same example. I ran your code on my
local and it did work perfectly. I could see some checkstyle errors that I
think travis might pick them up.
I have a suggestion for the sake of example scenario.
For the `alerts` event you using `LocalTime` which indicate when `alerts`
occurred, it would be useful also add `warnings` timestamp to `alerts` event in
order to show when racks temperature passed the threshold, something like this
on
[line](https://github.com/kisimple/flink/blob/5cd3a374b84b2a7aaedb4c4184caded073e19295/flink-examples/flink-examples-cep/src/main/java/org/apache/flink/cep/examples/java/monitoring/TemperatureMonitoring.java#L133)
`out.collect(new TemperatureAlert(first.getRackID(), second.getDatetime()));
`
of course it needs to update the `TemperatureAlert` model also.
> Add CEP examples
> ----------------
>
> Key: FLINK-4303
> URL: https://issues.apache.org/jira/browse/FLINK-4303
> Project: Flink
> Issue Type: Improvement
> Components: CEP
> Affects Versions: 1.1.0
> Reporter: Timo Walther
> Assignee: blues zheng
> Priority: Major
>
> Neither CEP Java nor CEP Scala contain a runnable example. The example on the
> website is also not runnable without adding some additional code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
