[
https://issues.apache.org/jira/browse/FLINK-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505776#comment-16505776
]
ASF GitHub Bot commented on FLINK-9538:
---------------------------------------
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/6134#discussion_r193968855
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFunction.java
---
@@ -25,13 +25,13 @@
* <p>This functionality is only available through the
* {@code BroadcastConnectedStream.process(final
KeyedBroadcastProcessFunction function)}.
*/
-public abstract class KeyedStateFunction<K, S extends State> {
+public interface KeyedStateFunction<K, S extends State> {
--- End diff --
IMO changing every test that uses this function is not the best practice.
Anonymous functions are still a valid option, so there is no need to change
valid tests. I would be in favour of adding just a single test that tests
lambda can be passed.
> Make KeyedStateFunction an interface
> ------------------------------------
>
> Key: FLINK-9538
> URL: https://issues.apache.org/jira/browse/FLINK-9538
> Project: Flink
> Issue Type: Improvement
> Reporter: Dawid Wysakowicz
> Assignee: vinoyang
> Priority: Major
>
> I suggest to change the KeyedStateFunction from abstract class to interface
> (FunctionalInterface in particular) to enable passing lambdas.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
