[ 
https://issues.apache.org/jira/browse/FLINK-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507779#comment-16507779
 ] 

ASF GitHub Bot commented on FLINK-9564:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6145

    [FLINK-9564][tests] Expose flink-end-to-end module directory to tests

    ## What is the purpose of the change
    
    This PR exposes the `flink-end-to-end-tests` module directory to test 
scripts for safer access to jars in sub-modules.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9564

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6145
    
----
commit 08a9d12d88efa660f7ddadd5162c3fe44c1003c9
Author: zentol <chesnay@...>
Date:   2018-06-11T07:52:28Z

    [FLINK-9564][tests] Expose flink-end-to-end module directory to tests

----


> Expose end-to-end module directory to test scripts
> --------------------------------------------------
>
>                 Key: FLINK-9564
>                 URL: https://issues.apache.org/jira/browse/FLINK-9564
>             Project: Flink
>          Issue Type: New Feature
>          Components: Tests
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.6.0, 1.5.1
>
>
> Several end-to-end tests access jars from modules in 
> {{flink-end-to-end-tests}}.
> To achieve this they use this hacky solutions like
> {{$TEST_DATA_DIR/../../<module>}} or {{$TEST_INFRA_DIR/../../<module>}}.
> This is brittle as hell can cause tests to fail by merely adding another 
> directory layer.
> We should instead export the flink-end-to-end directory in the 
> pre-commit/nightly scripts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to