Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/934#discussion_r35634886
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/BaseAccumulatorSnapshot.java
 ---
    @@ -44,18 +39,11 @@
         */
        private final SerializedValue<Map<AccumulatorRegistry.Metric, 
Accumulator<?, ?>>> flinkAccumulators;
     
    -   /**
    -    * Serialized user accumulators which may require the custom user class 
loader.
    -    */
    -   private final SerializedValue<Map<String, Accumulator<?, ?>>> 
userAccumulators;
    -
    -   public AccumulatorSnapshot(JobID jobID, ExecutionAttemptID 
executionAttemptID,
    -                                                   
Map<AccumulatorRegistry.Metric, Accumulator<?, ?>> flinkAccumulators,
    -                                                   Map<String, 
Accumulator<?, ?>> userAccumulators) throws IOException {
    +   public BaseAccumulatorSnapshot(JobID jobID, ExecutionAttemptID 
executionAttemptID,
    +                   Map<AccumulatorRegistry.Metric, Accumulator<?, ?>> 
flinkAccumulators) throws IOException {
                this.jobID = jobID;
                this.executionAttemptID = executionAttemptID;
                this.flinkAccumulators = new 
SerializedValue<Map<AccumulatorRegistry.Metric, Accumulator<?, 
?>>>(flinkAccumulators);
    --- End diff --
    
    Why are the `flinkAccumulators` in `BaseAccumulatorSnapshot`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to