[ 
https://issues.apache.org/jira/browse/FLINK-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508191#comment-16508191
 ] 

Mahesh Senniappan commented on FLINK-6670:
------------------------------------------

Hello [~Zentol], I saw your comment in a starter issue, FLINK-5860, related to 
this issue. I haven't contributed to Flink before, do you think I can take a 
look into this?

> remove CommonTestUtils.createTempDirectory()
> --------------------------------------------
>
>                 Key: FLINK-6670
>                 URL: https://issues.apache.org/jira/browse/FLINK-6670
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Nico Kruber
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> {{CommonTestUtils.createTempDirectory()}} encourages a dangerous design 
> pattern with potential concurrency issues in the unit tests as well as the 
> need to cleanup the created directories.
> Instead, it should be solved by using the following pattern:
> {code:java}
>         @Rule
>         public TemporaryFolder tempFolder = new TemporaryFolder();
> {code}
> We should therefore remove {{CommonTestUtils.createTempDirectory()}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to