Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r194458815
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/FunctionDescriptor.scala
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors
+
+/**
+ * Function Descriptor
+ */
+class FunctionDescriptor(var name: String) extends Descriptor {
--- End diff --
As mentioned before, we should document every method and have more fluent
method names.
E.g.
```
Function.using(...)
```
I know `Function` is pretty generic but we do the same with `Kafka`,
`Filesystem` etc.
---
