GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6152

    9467

    ## What is the purpose of the change
    
    This PR fixes the watermark display in the WebUI.
    
    When we reworked the watermark metrics we renamed the metrics and moved 
them to the operator level.
    
    We never adjusted the UI for these changes. The renaming itself was easy to 
fix, the move to the operator level less so as the UI is not aware of 
operators. This showed that the upgrade path from task to operator watermark 
metrics isn't as easy as it should be. As such, once again, we expose the input 
watermark also on the task level.
    
    We could have a discussion about exposing all watermark metrics also for 
tasks, but this is rather involved for the output watermarks. (particularly so 
since we never planned for it)
    
    ## Brief change log
    
    * expose `currentInputWatermark` also for the task
    * rename queried metric name in UI
    
    ## Verifying this change
    
    * manually verified, start a local cluster, run the `TopSpeedWindowing` 
example, check watermark tab in UI
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9467

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6152
    
----
commit 6244b11009d6ce0025edd60c1c765432c0bf57f7
Author: zentol <chesnay@...>
Date:   2018-06-05T11:51:08Z

    [FLINK-9467][metrics][WebUI] Fix watermark display

commit 5d5825166ebc9faea9315e3e0d09cca40d716743
Author: zentol <chesnay@...>
Date:   2018-06-05T11:51:29Z

    [FLINK-9467][metrics] Rebuild UI

----


---

Reply via email to