[
https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510992#comment-16510992
]
ASF GitHub Bot commented on FLINK-9280:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6147#discussion_r195049953
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheDirectoriesTest.java
---
@@ -206,4 +200,49 @@ public void testDirectoryCleanUp() throws Exception {
}
}
}
+
+ @Test
+ public void testCompression() throws IOException {
+ final java.nio.file.Path compressDir =
temporaryFolder.newFolder("compressDir").toPath();
+ final java.nio.file.Path extractDir =
temporaryFolder.newFolder("extractDir").toPath();
+
+ final java.nio.file.Path originalDir = Paths.get("rootDir");
+ final java.nio.file.Path emptySubDir =
originalDir.resolve("emptyDir");
+ final java.nio.file.Path fullSubDir =
originalDir.resolve("fullDir");
+ final java.nio.file.Path file1 = originalDir.resolve("file1");
+ final java.nio.file.Path file2 = originalDir.resolve("file2");
+ final java.nio.file.Path file3 = fullSubDir.resolve("file3");
+
+ Files.createDirectory(compressDir.resolve(originalDir));
+ Files.createDirectory(compressDir.resolve(emptySubDir));
+ Files.createDirectory(compressDir.resolve(fullSubDir));
+ Files.copy(new
ByteArrayInputStream(testFileContent.getBytes(StandardCharsets.UTF_8)),
compressDir.resolve(file1));
+ Files.createFile(compressDir.resolve(file2));
+ Files.copy(new
ByteArrayInputStream(testFileContent.getBytes(StandardCharsets.UTF_8)),
compressDir.resolve(file3));
+
+ final Path zip = FileCache.compressDirectory(new
Path(compressDir.resolve(originalDir).toString()));
+
+ FileCache.expandDirectory(new File(zip.getPath()),
extractDir.toFile(), false);
+
+ assertTrue(Files.exists(extractDir.resolve(originalDir)));
--- End diff --
Maybe we could make the whole directory tree comparison more automated by
following https://stackoverflow.com/a/39584230/4815083. What do you think?
> Extend JobSubmitHandler to accept jar files
> -------------------------------------------
>
> Key: FLINK-9280
> URL: https://issues.apache.org/jira/browse/FLINK-9280
> Project: Flink
> Issue Type: New Feature
> Components: Job-Submission, REST
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Critical
> Fix For: 1.6.0, 1.5.1
>
>
> The job submission through the CLI first uploads all require jars to the blob
> server, sets the blob keys in the jobgraph, and then uploads this graph to
> The {{JobSubmitHandler}} which submits it to the Dispatcher.
> This process has the downside that it requires jars to be uploaded to the
> blobserver before submitting the job graph, which does not happen via REST.
> I propose an extension to the the {{JobSubmitHandler}} to also accept an
> optional list of jar files, that were previously uploaded through the
> {{JarUploadHandler}}. If present, the handler would upload these jars to the
> blobserver and set the blob keys.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
