[
https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511229#comment-16511229
]
ASF GitHub Bot commented on FLINK-9280:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6147#discussion_r195102896
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/AbstractHandler.java
---
@@ -119,6 +121,10 @@ protected void respondAsLeader(ChannelHandlerContext
ctx, RoutedRequest routedRe
}
//noinspection unchecked
request = (R) new FileUpload(path);
+ } else if (untypedResponseMessageHeaders ==
JobSubmitHeaders.getInstance()) {
+ final JobSubmitRequestBody jobSubmission =
ctx.channel().attr(FileUploadHandler.SUBMITTED_JOB).get();
+ //noinspection unchecked
+ request = (R) jobSubmission;
--- End diff --
Not sure whether I would make the job submission a special case here. What
if other requests will allow in the future to upload files as well.
Alternatively, we could make the attribute map or the set of uploaded files
accessible to the `AbstractRestHandler` implementations. Then every handler
could implement the support for uploaded files themselves. What do you think?
> Extend JobSubmitHandler to accept jar files
> -------------------------------------------
>
> Key: FLINK-9280
> URL: https://issues.apache.org/jira/browse/FLINK-9280
> Project: Flink
> Issue Type: New Feature
> Components: Job-Submission, REST
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Critical
> Fix For: 1.6.0, 1.5.1
>
>
> The job submission through the CLI first uploads all require jars to the blob
> server, sets the blob keys in the jobgraph, and then uploads this graph to
> The {{JobSubmitHandler}} which submits it to the Dispatcher.
> This process has the downside that it requires jars to be uploaded to the
> blobserver before submitting the job graph, which does not happen via REST.
> I propose an extension to the the {{JobSubmitHandler}} to also accept an
> optional list of jar files, that were previously uploaded through the
> {{JarUploadHandler}}. If present, the handler would upload these jars to the
> blobserver and set the blob keys.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
