Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6149#discussion_r195137063
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
 ---
    @@ -88,6 +90,12 @@
        /** The nanoseconds that a stream may spend not writing any bytes 
before it is closed as inactive. */
        private final long streamInactivityTimeoutNanos;
     
    +   /** Rate limiter of incoming bytes for this filesystem. */
    +   private final RateLimiter inputRateLimiter;
    --- End diff --
    
    Instead of nullable field, please use `Optional<RateLimiter>` on both 
fields. annotating `@Nullable` wouldn't suffice, since unfortunately we do not 
enforce such annotation and `Optional` is always enforced.


---

Reply via email to