[
https://issues.apache.org/jira/browse/FLINK-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512185#comment-16512185
]
ASF GitHub Bot commented on FLINK-9560:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195346228
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -1032,19 +1113,50 @@ public ConnectionLimitingSettings(
int limitOutput,
long streamOpenTimeout,
long streamInactivityTimeout) {
+ this(limitTotal, limitInput, limitOutput,
streamOpenTimeout, streamInactivityTimeout, 0, 0);
+ }
+
+
+ /**
+ * Creates a new ConnectionLimitingSettings with the given
parameters.
+ *
+ * @param limitTotal The limit for the total number of
connections, or 0, if no limit.
+ * @param limitInput The limit for the number of input stream
connections, or 0, if no limit.
+ * @param limitOutput The limit for the number of output stream
connections, or 0, if no limit.
+ * @param streamOpenTimeout The maximum number of
milliseconds that the file system will wait when
+ * no more connections are
currently permitted.
+ * @param streamInactivityTimeout The milliseconds that a
stream may spend not writing any
+ * bytes before it is closed as
inactive.
+ * @param rateLimitingInputBytesPerSecond the allowed rate
(bytes/s) that can be red from FileSystem
--- End diff --
same here - in whole file, please unify argument naming with the config
parameter (`rateLimitingInput***` -> `limitInputRateBytesPerSecond`
> RateLimiting for FileSystem
> ---------------------------
>
> Key: FLINK-9560
> URL: https://issues.apache.org/jira/browse/FLINK-9560
> Project: Flink
> Issue Type: Improvement
> Components: FileSystem
> Affects Versions: 1.5.0
> Reporter: Etienne CARRIERE
> Priority: Major
>
> *Pain*: On our system, we see that during checkpoint , all the bandwidth is
> take to send the checkpoint to object storage (s3 in our case)
> *Proposal* : After the creation of some limitation on Filesystem (mostly
> number of connections with the tickets FLINK-8125/FLINK-8198/FLINK-9468), I
> propose to add ratelimiting "per Filesystem" .
> *Proposal of implementation* : Modify LimitedConnectionsFileSystem to add a
> ratelimiter on both Input and OutputStream.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
