[
https://issues.apache.org/jira/browse/FLINK-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512348#comment-16512348
]
ASF GitHub Bot commented on FLINK-9257:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6053
```
==============================================================================
Running 'Streaming Python Wordcount end-to-end test'
==============================================================================
Flink dist directory: /home/travis/build/apache/flink/build-target
TEST_DATA_DIR:
/home/travis/build/apache/flink/flink-end-to-end-tests/test-scripts/temp-test-directory-10412258255
Starting cluster.
Starting standalonesession daemon on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
Starting taskexecutor daemon on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Dispatcher REST endpoint is up.
Starting execution of program
Program execution finished
Job with JobID 06184a085272dd12b3573b1bcb96badc has finished.
Job Runtime: 6103 ms
pass StreamingPythonWordCount
Stopping taskexecutor daemon (pid: 31303) on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
Stopping standalonesession daemon (pid: 30988) on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
[PASS] 'Streaming Python Wordcount end-to-end test' passed after 0 minutes
and 24 seconds! Test exited with exit code 0.
==============================================================================
Running 'Wordcount end-to-end test'
==============================================================================
Flink dist directory: /home/travis/build/apache/flink/build-target
TEST_DATA_DIR:
/home/travis/build/apache/flink/flink-end-to-end-tests/test-scripts/temp-test-directory-36174383269
Starting cluster.
Starting standalonesession daemon on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
Starting taskexecutor daemon on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Waiting for dispatcher REST endpoint to come up...
Dispatcher REST endpoint is up.
Starting execution of program
Program execution finished
Job with JobID 30256ad7ff23ea8543ddca76bacaaee5 has finished.
Job Runtime: 1352 ms
pass WordCount
Stopping taskexecutor daemon (pid: 835) on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
Stopping standalonesession daemon (pid: 517) on host
travis-job-363a754a-fe5f-4873-bbe8-fe4064b95bc8.
[PASS] 'Wordcount end-to-end test' passed after 0 minutes and 11 seconds!
Test exited with exit code 0.
```
Travis logs excerpt looks good. Follow up commits looks good.
+1, LGTM on my side.
> End-to-end tests prints "All tests PASS" even if individual test-script
> returns non-zero exit code
> --------------------------------------------------------------------------------------------------
>
> Key: FLINK-9257
> URL: https://issues.apache.org/jira/browse/FLINK-9257
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Florian Schmidt
> Assignee: Florian Schmidt
> Priority: Critical
> Fix For: 1.6.0
>
>
> In some cases the test-suite exits with non-zero exit code but still prints
> "All tests PASS" to stdout. This happens because how the test runner works,
> which is roughly as follows
> # Either run-nightly-tests.sh or run-precommit-tests.sh executes a suite of
> tests consisting of one multiple bash scripts.
> # As soon as one of those bash scripts exists with non-zero exit code, the
> tests won't continue to run and the test-suite will also exit with non-zero
> exit code.
> # *During the cleanup hook (trap cleanup EXIT in common.sh) it will be
> checked whether there are non-empty out files or log files with certain
> exceptions. If a tests fails with non-zero exit code, but does not have any
> exceptions or .out files, this will still print "All tests PASS" to stdout,
> even though they don't*
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
