Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6083#discussion_r195453836
  
    --- Diff: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml ---
    @@ -0,0 +1,228 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +   <parent>
    +           <artifactId>flink-end-to-end-tests</artifactId>
    +           <groupId>org.apache.flink</groupId>
    +           <version>1.6-SNAPSHOT</version>
    +   </parent>
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <artifactId>flink-confluent-schema-registry</artifactId>
    +   <properties>
    +           
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +           <scala.binary.version>2.11</scala.binary.version>
    +           <confluent.version>4.1.0</confluent.version>
    +           <json2avro.version>0.2.6</json2avro.version>
    +           <maven.compiler.source>1.8</maven.compiler.source>
    +   </properties>
    +
    +   <dependencies>
    +           <!-- Apache Flink dependencies -->
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-core</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <!-- This dependency is required to actually execute 
jobs. It is currently pulled in by
    +                flink-streaming-java, but we explicitly depend on it to 
safeguard against future changes. -->
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-clients_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-scala_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   
<artifactId>flink-streaming-scala_${scala.binary.version}</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    --- End diff --
    
    I think we can replace the two Scala dependencies above with
    ```
    <dependency>
                        <groupId>org.apache.flink</groupId>
                        
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
                        <version>${project.version}</version>
    </dependency>
    ```


---

Reply via email to