Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/6154#discussion_r195613671
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedLeaderService.java
---
@@ -356,8 +357,8 @@ public void confirmLeaderSessionID(UUID
leaderSessionID) {
}
@Override
- public boolean hasLeadership() {
- return isLeader;
+ public boolean hasLeadership(@Nonnull UUID leaderSessionId) {
+ return isLeader &&
leaderSessionId.equals(currentLeaderSessionId);
}
--- End diff --
Thanks @tillrohrmann Makes sense better to me now. Yea, I did not see there
has a volatile in there before. Thanks again.
---
