[ 
https://issues.apache.org/jira/browse/FLINK-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513767#comment-16513767
 ] 

ASF GitHub Bot commented on FLINK-9588:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6168#discussion_r195719361
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -662,13 +662,13 @@ private void addComputationState(
                        ComputationState computationState) {
                final Stack<State<T>> statesToCheck = new Stack<>();
                statesToCheck.push(state);
    -
    +           ConditionContext<T> context = new ConditionContext<T>(this, 
sharedBuffer, computationState);
    --- End diff --
    
    How about creating the context only once at the very beginning of 
computeNextStates?


> Reuse the same conditionContext with in a same computationState
> ---------------------------------------------------------------
>
>                 Key: FLINK-9588
>                 URL: https://issues.apache.org/jira/browse/FLINK-9588
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>            Reporter: aitozi
>            Assignee: aitozi
>            Priority: Major
>
> Now cep checkFilterCondition with a newly created Conditioncontext for each 
> edge, which will result in the repeatable getEventsForPattern because of the 
> different Conditioncontext Object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to