[ https://issues.apache.org/jira/browse/FLINK-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514806#comment-16514806 ]
ASF GitHub Bot commented on FLINK-9585: --------------------------------------- GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6175 [FLINK-9585] Logger in ZooKeeperStateHandleStore is public and non-final ## What is the purpose of the change *This pull request mark Logger in ZooKeeperStateHandleStore as private and final* ## Brief change log - *Changed Logger in `ZooKeeperStateHandleStore` from `public` to `private final`* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) You can merge this pull request into a Git repository by running: $ git pull https://github.com/yanghua/flink FLINK-9585 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6175.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6175 ---- commit 70b1c5c5acf26b44e79922924d3efc11357067d2 Author: yanghua <yanghua1127@...> Date: 2018-06-16T14:58:14Z [FLINK-9585] Logger in ZooKeeperStateHandleStore is public and non-final ---- > Logger in ZooKeeperStateHandleStore is public and non-final > ----------------------------------------------------------- > > Key: FLINK-9585 > URL: https://issues.apache.org/jira/browse/FLINK-9585 > Project: Flink > Issue Type: Bug > Components: Local Runtime > Affects Versions: 1.5.0, 1.6.0 > Reporter: Chesnay Schepler > Assignee: vinoyang > Priority: Trivial > > The logger in {{ZooKeeperStateHandleStore}} should be private and final. -- This message was sent by Atlassian JIRA (v7.6.3#76005)