GitHub user kent2171 opened a pull request:

    https://github.com/apache/flink/pull/6176

    [FLINK-9603][connector-filesystem] fix part indexing, when part suffix is 
specified

    This pull-request fixes problem of incorrect part file index lookup, when 
part suffix is specified.
    Part file path should be assembled with part suffix, before check on 
existance
    
    The following tests, that verify part file indexing, have been added:
    - 
testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInProgressState
    - 
testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInPendingState
    - 
testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInFinalState
    - 
testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInProgressState
    - 
testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInPendingState
    - 
testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInFinalState

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kent2171/flink FLINK-9603_fix_part_idx_inc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6176
    
----
commit c08b81044bf80d5633a9936afb73fadf021cef47
Author: Rinat Sharipov <r.sharipov@...>
Date:   2018-06-17T13:03:54Z

    FLINK-9603 1. all logic, that is responsible for path assembly moved into 
method; 2. test logic of part file indexing, when in-progress/ pending/ final 
part files already exists in bucket; 3. test the same logic, when part file has 
suffix

----


---

Reply via email to