[ 
https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515608#comment-16515608
 ] 

ASF GitHub Bot commented on FLINK-9571:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6173#discussion_r196046444
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
 ---
    @@ -392,14 +268,14 @@ public KeyGroupRange getKeyGroupRange() {
                        kvStateRegistry.registerKvState(keyGroupRange, name, 
kvState);
                }
     
    -           return state;
    +           return (S) kvState;
    --- End diff --
    
    For the future we should think about a way to bind the state type of the 
state descriptor also to the internal state type, so that the factory can 
produce a proper generic type that reflects matches the state descriptor but 
also is an `InternalKvState`. For now, I see no simple solution, but we might 
want to keep this in mind and discuss with @aljoscha .


> Switch to internal states in StateBinder
> ----------------------------------------
>
>                 Key: FLINK-9571
>                 URL: https://issues.apache.org/jira/browse/FLINK-9571
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.6.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>             Fix For: 1.6.0
>
>
> The StateBinder factory for state objects is not a part of public API and it 
> produces in fact only internal states.
> It can be changed it to produce internal state interfaces instead of public 
> API.
> This can help to expose internal state API for internal components which use 
> the factory, e.g. for state TTL wrappers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to