[
https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515610#comment-16515610
]
ASF GitHub Bot commented on FLINK-6469:
---------------------------------------
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5448
Hi @yanghua,
I am afraid Stephan won't be able to reply any time soon. I would suggest
to
- add the default unit to the parse method of `MemorySize` and use MB for
`MANAGED_MEMORY_SIZE`.
- change the return value of getMebiBytes() to int or have a
getMebiBytesAsInt() method that uses a MathUtils.checkedDownCast() to avoid
unnoticed overflow errors, as Stephan commented
- change the default value of `MANAGED_MEMORY_SIZE` to 0, as suggested by
@zentol
After that I think this PR will be ready to be merged.
> Configure Memory Sizes with units
> ---------------------------------
>
> Key: FLINK-6469
> URL: https://issues.apache.org/jira/browse/FLINK-6469
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
>
> Currently, memory sizes are configured by pure numbers, the interpretation is
> different from configuration parameter to parameter.
> For example, heap sizes are configured in megabytes, network buffer memory is
> configured in bytes, alignment thresholds are configured in bytes.
> I propose to configure all memory parameters the same way, with units similar
> to time. The JVM itself configured heap size similarly: {{Xmx5g}} or
> {{Xmx2000m}}.
> {code}
> 10000 -> bytes
> 10 kb
> 64 mb
> 1 gb
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
