[
https://issues.apache.org/jira/browse/FLINK-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516863#comment-16516863
]
ASF GitHub Bot commented on FLINK-9187:
---------------------------------------
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
@zentol , thanks for review.
first, there is a small point that the IDs may be duplicated when use JM/TM
actual unique ID to compose the job name of pushgateway, like the picture below.
second, when config the grafana dashboard, the prefix of the pushgateway
job name is useful, the uniq ID may not useful, because our metric data
contains (`jm_id`, `tm_id`).
so, for pushgateway, the jobName is used to distinguish different services.
for grafana, the prefix of jobName can use to distinguish different
clusters, we also can just use JM/TM ID and ignore the jobName.
`FLINK-9543` is useful and important. I tried to finished it.
Is't ok to use `resourceId` to represent the JM‘ID?
```java
public abstract class ResourceManager ...{
public static final String RESOURCE_MANAGER_NAME = "resourcemanager";
/** Unique id of the resource manager. */
private final ResourceID resourceId;
```
> add prometheus pushgateway reporter
> -----------------------------------
>
> Key: FLINK-9187
> URL: https://issues.apache.org/jira/browse/FLINK-9187
> Project: Flink
> Issue Type: New Feature
> Components: Metrics
> Affects Versions: 1.4.2
> Reporter: lamber-ken
> Priority: Minor
> Labels: features
> Fix For: 1.6.0
>
>
> make flink system can send metrics to prometheus via pushgateway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
