GitHub user addisonj opened a pull request:
https://github.com/apache/flink/pull/6183
[FLINK-9616][metrics] Fix datadog to include shaded deps
## What is the purpose of the change
This fixes a broken build that wasn't properly including a shaded in the
jar it builds. This causes the instantiation of DatadogHttpReporter to fail and
with no easy way to fix since the dependencies exist on a shaded import path.
## Brief change log
- Changes
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
However, it can be validated by:
```
cd flink-metrics/flink-metrics-datadog
mvn package
jar tf target/flink-metrics-datadog-1.6-SNAPSHOT.jar
```
And then seeing the expected okhttp3 and okio dependencies being included
in the resulting jar.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes, but brings in
line with documented behavior here:
https://ci.apache.org/projects/flink/flink-docs-release-1.5/monitoring/metrics.html#datadog-orgapacheflinkmetricsdatadogdatadoghttpreporter
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/instructure/flink datadog_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6183
----
commit 10fe56a9adbe6f35dc4b5fae0e7478e99028f5f7
Author: Addison Higham <ahigham@...>
Date: 2018-06-19T14:49:56Z
[FLINK-9616] Fix datadog to include shaded deps
flink-metrics-datadog wasn't properly included it's shaded dependencies
in the jar it builds.
Looking at other places where shaded dependecies are used, it seems like
the build wasn't working as intended.
----
---
