[
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645737#comment-14645737
]
ASF GitHub Bot commented on FLINK-2399:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-125886476
Using `getClass().getPackage().getImplementationVersion()` would be a
decent first approach then, I guess. The critical part seems to be the
Client-to-JobManager communication.
How about the following as a first step: The client sends its version
together with the `SubmitJob` message (just add a field there). The JobManager
would check the version and respond with a failure, if it does not match. You
can probably make the JobManager part very simple, no need to add extra
constructor parameters, etc.
That way, the change would be minimally invasive, and we could see how well
it addresses the issues, and whether we should extend this to other messages as
well.
> Fail when actor versions don't match
> ------------------------------------
>
> Key: FLINK-2399
> URL: https://issues.apache.org/jira/browse/FLINK-2399
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, TaskManager
> Affects Versions: 0.9, master
> Reporter: Ufuk Celebi
> Assignee: Sachin Goel
> Priority: Minor
> Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions
> communicate with each other, for example when an old client (e.g. Flink 0.9)
> communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the
> actors and fail if they don't match.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
