Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6178#discussion_r196701452
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java
---
@@ -116,5 +136,16 @@ private void reset() {
currentHttpPostRequestDecoder.destroy();
currentHttpPostRequestDecoder = null;
currentHttpRequest = null;
+ currentUploadDir = null;
+ currentJsonPayload = null;
+ }
+
+ public static Optional<byte[]>
getMultipartJsonPayload(ChannelHandlerContext ctx) {
+ return
Optional.ofNullable(ctx.channel().attr(UPLOADED_JSON).get());
+ }
+
+ public static FileUploads getMultipartFileUploads(ChannelHandlerContext
ctx) {
+ return
Optional.ofNullable(ctx.channel().attr(UPLOADED_FILES).get())
+ .orElse(FileUploads.EMPTY);
--- End diff --
I think not much. My gut feeling is just that `FileUploads` can be
simplified. Instead of having our own FileVisitor, we could simply call
`FileUtils.deleteDirectory(uploadDirectory)`. And I think this class has
actually two responsibilities: Listing all files to make them accessible and
storing the directories in which they reside to delete them afterwards.
---
