[ 
https://issues.apache.org/jira/browse/FLINK-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519096#comment-16519096
 ] 

ASF GitHub Bot commented on FLINK-9599:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/6178
  
    Checkstyle errors:
    ```
    18:31:10.780 [INFO] There are 2 errors reported by Checkstyle 8.4 with 
/tools/maven/checkstyle.xml ruleset.
    18:31:10.788 [ERROR] 
src/main/java/org/apache/flink/runtime/rest/handler/FileUploads.java:[56] 
(regexp) RegexpSingleline: Trailing whitespace
    18:31:10.804 [ERROR] 
src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java:[99] 
(regexp) RegexpSingleline: Trailing whitespace
    ```


> Implement generic mechanism to receive files via rest
> -----------------------------------------------------
>
>                 Key: FLINK-9599
>                 URL: https://issues.apache.org/jira/browse/FLINK-9599
>             Project: Flink
>          Issue Type: New Feature
>          Components: REST
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> As a prerequisite for a cleaner implementation of FLINK-9280 we should
>  * extend the RestClient to allow the upload of Files
>  * extend FileUploadHandler to accept mixed multi-part requests (json + files)
>  * generalize mechanism for accessing uploaded files in {{AbstractHandler}}
> Uploaded files can be forwarded to subsequent handlers as an attribute, 
> similar to the existing special case for the {{JarUploadHandler}}. The JSON 
> body can be forwarded by replacing the incoming http requests with a simple 
> {{DefaultFullHttpRequest}}.
> Uploaded files will be retrievable through the {{HandlerRequest}}.
> I'm not certain if/how we can document that a handler accepts files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to