[
https://issues.apache.org/jira/browse/FLINK-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519453#comment-16519453
]
ASF GitHub Bot commented on FLINK-9627:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6198
[FLINK-9627] Extending KafkaJsonTableSource according to comments will
result in NPE
## What is the purpose of the change
* This pull request fixed a NPE when customize KafkaJsonTableSource without
Builder*
## Brief change log
- *Initialize the `StartupMode ` field with a enum value*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9627
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6198
----
commit 1dfe2b01921d437485523418c44739ee91febaa5
Author: yanghua <yanghua1127@...>
Date: 2018-06-21T08:46:53Z
[FLINK-9627] Extending KafkaJsonTableSource according to comments will
result in NPE
----
> Extending 'KafkaJsonTableSource' according to comments will result in NPE
> -------------------------------------------------------------------------
>
> Key: FLINK-9627
> URL: https://issues.apache.org/jira/browse/FLINK-9627
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Dominik Wosiński
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> According to the comments what is needed to extend the 'KafkaJsonTableSource'
> looks as follows:
>
> {code:java}
> A version-agnostic Kafka JSON {@link StreamTableSource}.
> *
> * <p>The version-specific Kafka consumers need to extend this class and
> * override {@link #createKafkaConsumer(String, Properties,
> DeserializationSchema)}}.
> *
> * <p>The field names are used to parse the JSON file and so are the
> types.{code}
> This will cause an NPE, since there is no default value for startupMode in
> the abstract class itself only in the builder of this class.
> For the 'getKafkaConsumer' method the switch statement will be executed on
> non-initialized 'startupMode' field:
> {code:java}
> switch (startupMode) {
> case EARLIEST:
> kafkaConsumer.setStartFromEarliest();
> break;
> case LATEST:
> kafkaConsumer.setStartFromLatest();
> break;
> case GROUP_OFFSETS:
> kafkaConsumer.setStartFromGroupOffsets();
> break;
> case SPECIFIC_OFFSETS:
> kafkaConsumer.setStartFromSpecificOffsets(specificStartupOffsets);
> break;
> }{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
