[
https://issues.apache.org/jira/browse/FLINK-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519779#comment-16519779
]
ASF GitHub Bot commented on FLINK-9624:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6199
[FLINK-9624][runtime] Move jar/artifact upload out of jobgraph
## What is the purpose of the change
This PR moves the logic for uploading jars/artifacts from the jobgraph into
a separate utility class usable by all submission methods.
The new `ClientUtils` class exposes 2 methods for uploading jars/artifacts
and setting the respective blob keys on the `JobGraph`.
All existing job-submission method were updated to use the new utilities
and should now behave the same.
The subsumed methods in `JobGraph` were removed, but remnants of them
remain in 2 added methods:
* setUserArtifactBlobKey sets the blobkey for a specific entry
* finalizeUserArtifactEntries writes the artifact entries into the
`ExecutionConfig`
## Verifying this change
* `ClientUtils` is tested in `ClientUtilsTest`
* `JobGraph` changes are covered in `JobGraphTest`
* client modifications are covered by various existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9280_delta
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6199
----
commit 13e3dc7dc9c0b7205223368a460993a309cb58ad
Author: zentol <chesnay@...>
Date: 2018-06-13T16:21:21Z
[FLINK-9624][runtime] Move jar/artifact upload out of jobgraph
----
> Move jar/artifact upload logic out of JobGraph
> ----------------------------------------------
>
> Key: FLINK-9624
> URL: https://issues.apache.org/jira/browse/FLINK-9624
> Project: Flink
> Issue Type: Improvement
> Components: Job-Submission
> Affects Versions: 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The {{JobGraph}} offers utility methods for uploading jars and artifacts to
> the BlobService.
> However, how these files are uploaded isn't a concern of the {{JobGraph}} but
> the submission-method, like the {{RestClusterClient}}.
> These methods should be moved into a utility class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
