[
https://issues.apache.org/jira/browse/FLINK-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520180#comment-16520180
]
ASF GitHub Bot commented on FLINK-9493:
---------------------------------------
GitHub user azagrebin opened a pull request:
https://github.com/apache/flink/pull/6202
[FLINK-9493] Forward cause when releasing a TaskManager at the SlotPool
## What is the purpose of the change
This PR is to propagate original cause from components calling
`SlotPoolGateway::releaseTaskManager`
## Brief change log
- adjust `SlotPoolGateway::releaseTaskManager` to accept cause
- propagate cause in `SlotPool` from other components
- generate cause in case of `SlotPool::postStop`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/azagrebin/flink FLINK-9493
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6202
----
commit ea2d2519a2e33ab08e4b862d0b3df63f0507d0ce
Author: Andrey Zagrebin <azagrebin@...>
Date: 2018-06-21T17:43:42Z
[FLINK-9493] Forward cause when releasing a TaskManager at the SlotPool
----
> Forward exception when releasing a TaskManager at the SlotPool
> --------------------------------------------------------------
>
> Key: FLINK-9493
> URL: https://issues.apache.org/jira/browse/FLINK-9493
> Project: Flink
> Issue Type: Bug
> Components: JobManager
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.6.0, 1.5.1
>
>
> We should add a cause when calling {{SlotPool#releaseTaskManager}} because
> the release operation can be the final root cause of the job failure.
> Currently, we create a generic exception which hides the true reason for the
> release operation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
