[ 
https://issues.apache.org/jira/browse/FLINK-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520305#comment-16520305
 ] 

ASF GitHub Bot commented on FLINK-4301:
---------------------------------------

GitHub user xueyumusic opened a pull request:

    https://github.com/apache/flink/pull/6204

    [FLINK-4301][docs] add version for quickstart script

    
    ## What is the purpose of the change
    This PR add version for quickstart script in the doc
    
    ## Brief change log
    one-line change add version argument
    
    ## Verifying this change
    build doc verified
    
    ## Does this pull request potentially affect one of the following parts:
    no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? docs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xueyumusic/flink addversion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6204
    
----
commit 3ff159e36416b6d824ab2d171f7f179d928971af
Author: xueyu <278006819@...>
Date:   2018-06-22T12:29:05Z

    add version for quickstart

----


> Parameterize Flink version in Quickstart bash script
> ----------------------------------------------------
>
>                 Key: FLINK-4301
>                 URL: https://issues.apache.org/jira/browse/FLINK-4301
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Timo Walther
>            Assignee: Simone Robutti
>            Priority: Major
>              Labels: pull-request-available, starter
>
> The Flink version is hard coded in the quickstart script (for Scala and 
> Java). Thus, even if a user is in the Flink 1.0 docs the scripts are 
> producing a quickstart of the Flink 1.1 release. It would be better if the 
> one-liner in the documentation would contain the version such that a Flink 
> 1.0 quickstart is built in the 1.0 documentation and 1.1 quickstart in the 
> 1.1 documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to