[ 
https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521025#comment-16521025
 ] 

ASF GitHub Bot commented on FLINK-9280:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6203
  
    There's a problem with how we designed the `FileUploads` cleanup. The 
`AbstractHandler` cleans it up when `AbstractHandler#respondToRequest` returns. 
There is however no guarantee that the request has been fully processed at this 
point, since `AbstractRestHandler` frequently processes requests asynchronously 
using `CompletableFutures`. In turn we may end up deleting files _before_ they 
have been processed or _while _ they are being processed.
    It appears we can only handle the cleanup in `AbstractHandler` if we let 
`AbstractHandler#respondToRequest` return a `CompletableFuture` that marks the 
finished request processing.


> Extend JobSubmitHandler to accept jar files
> -------------------------------------------
>
>                 Key: FLINK-9280
>                 URL: https://issues.apache.org/jira/browse/FLINK-9280
>             Project: Flink
>          Issue Type: New Feature
>          Components: Job-Submission, REST
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.0, 1.5.1
>
>
> The job submission through the CLI first uploads all require jars to the blob 
> server, sets the blob keys in the jobgraph, and then uploads this graph to 
> The {{JobSubmitHandler}} which submits it to the Dispatcher.
> This process has the downside that it requires jars to be uploaded to the 
> blobserver before submitting the job graph, which does not happen via REST.
> I propose an extension to the the {{JobSubmitHandler}} to also accept an 
> optional list of jar files, that were previously uploaded through the 
> {{JarUploadHandler}}. If present, the handler would upload these jars to the 
> blobserver and set the blob keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to