[
https://issues.apache.org/jira/browse/FLINK-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521103#comment-16521103
]
Mahesh Senniappan commented on FLINK-5860:
------------------------------------------
[~Zentol]
I have removed `java.io.tmpdir` in the following files:
{code:java}
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java
flink-core/src/test/java/org/apache/flink/testutils/TestConfigUtils.java
flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java
flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java
flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java
flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java
flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java
flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorITCase.java
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/CommonTestUtils.java{code}
Below are a few files where it was already removed in earlier commits by the
time I got to it.
{code:java}
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializationTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStateOutputStreamTest.java{code}
There are two utility methods in this class `TestBaseUtils` which are not used
anywhere. These can be deleted to prevent people using them in future. I would
like to hear your thoughts about this so I have not deleted them yet.
{code:java}
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java{code}
There are a few instances where `javaio.tmpdir` is not directly used in test
classes. Changing the below classes would bring in a lot of changes. I would
like to know if I am making progress in the right direction before I make
changes to these (if needed). It would be helpful if the changes so far can be
reviewed. Below is the commit from my fork that has the changes I have made so
far. I can submit a PR if it is required for review.
https://github.com/maheshsenni/flink/commit/41774d3f0f53cd433254b576468c2e5b5b690118
{code:java}
flink-runtime/src/test/java/org/apache/flink/runtime/util/TestingTaskManagerRuntimeInfo.java
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordCollectingResultPartitionWriter.java
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/example/CassandraTupleWriteAheadSinkExample.java{code}
> Replace all the file creating from java.io.tmpdir with TemporaryFolder
> ----------------------------------------------------------------------
>
> Key: FLINK-5860
> URL: https://issues.apache.org/jira/browse/FLINK-5860
> Project: Flink
> Issue Type: Test
> Components: Tests
> Reporter: shijinkui
> Assignee: Mahesh Senniappan
> Priority: Major
> Labels: starter
>
> Search `System.getProperty("java.io.tmpdir")` in whole Flink project. It will
> get a Unit test list. Replace all the file creating from `java.io.tmpdir`
> with TemporaryFolder.
> Who can fix this problem thoroughly?
> ```
> $ grep -ri 'System.getProperty("java.io.tmpdir")' .
> ./flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/example/CassandraTupleWriteAheadSinkExample.java:
> env.setStateBackend(new FsStateBackend("file:///" +
> System.getProperty("java.io.tmpdir") + "/flink/backend"));
> ./flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java:
> File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java:
> File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java:
> File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java:
> return getMockEnvironment(new File[] { new
> File(System.getProperty("java.io.tmpdir")) });
> ./flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
> public static final String DEFAULT_TASK_MANAGER_TMP_PATH =
> System.getProperty("java.io.tmpdir");
> ./flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java:
> final String tempPath = System.getProperty("java.io.tmpdir");
> ./flink-core/src/test/java/org/apache/flink/testutils/TestConfigUtils.java:
> final File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java:
> File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java:
> File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/util/KMeansDataGenerator.java:
> final String outDir = params.get("output",
> System.getProperty("java.io.tmpdir"));
> ./flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ml/util/LinearRegressionDataGenerator.java:
> final String tmpDir = System.getProperty("java.io.tmpdir");
> ./flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/util/WebLogDataGenerator.java:
> final String outPath = System.getProperty("java.io.tmpdir");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java:
> public static final String FLINK_PYTHON_FILE_PATH =
> System.getProperty("java.io.tmpdir") + File.separator + "flink_plan";
> ./flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java:
> public static final String FLINK_TMP_DATA_DIR =
> System.getProperty("java.io.tmpdir") + File.separator + "flink_data";
> ./flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java:
> FLINK_HDFS_PATH = "file:" +
> System.getProperty("java.io.tmpdir") + File.separator + "flink";
> ./flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java:
> baseDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java:
> return System.getProperty("java.io.tmpdir");
> ./flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/FlinkZooKeeperQuorumPeer.java:
> System.getProperty("java.io.tmpdir"),
> UUID.randomUUID().toString());
> ./flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializationTest.java:
> new String[] {
> System.getProperty("java.io.tmpdir") });
> ./flink-runtime/src/test/java/org/apache/flink/runtime/io/network/serialization/LargeRecordsTest.java:
> new String[] {
> System.getProperty("java.io.tmpdir") } );
> ./flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java:
> String path = System.getProperty("java.io.tmpdir");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStateOutputStreamTest.java:
> private static final Path TEMP_DIR_PATH = new Path(new
> File(System.getProperty("java.io.tmpdir")).toURI());
> ./flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java:
> File tempDir = new File(System.getProperty("java.io.tmpdir"));
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java:
> File out = new File(System.getProperty("java.io.tmpdir"),
> "jarcreatortest.jar");
> ./flink-runtime/src/test/java/org/apache/flink/runtime/util/TestingTaskManagerRuntimeInfo.java:
> this(new Configuration(),
> System.getProperty("java.io.tmpdir").split(",|" + File.pathSeparator));
> ./flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java:
> return
> configuration.getString(ConfigConstants.JOB_MANAGER_WEB_TMPDIR_KEY,
> System.getProperty("java.io.tmpdir"));
> ./flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala:
> System.getProperty("java.io.tmpdir"),
> ./flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java:
> new TestingTaskManagerRuntimeInfo(taskManagerConfig, new
> String[] {System.getProperty("java.io.tmpdir")}),
> ./flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java:
> String path = System.getProperty("java.io.tmpdir");
> ./flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/CommonTestUtils.java:
> return System.getProperty("java.io.tmpdir");
> ./flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java:
> String defaultPropertiesFileLocation =
> System.getProperty("java.io.tmpdir");
> ```
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
