Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/931#issuecomment-125979125
Thanks for the pull request @zentol!
+1 for removing the dill library. As far as I can see, we handle all the
serialization ourselves now. We only used the Dill library to serialize the
user-defined function alongside with the operator. Now, the operator is
extracted from the plan which has been distributed in the Python files to the
nodes beforehand. The plan is only send once to generate the Java execution
plan. The old behavior was to serialize the operator, pass it to Java, and sent
it back again during execution. Performance-wise the new implementation could
even be a bit faster.
+1 for explicitly passing the file paths. Java and Python have different
ways to determine temporary file paths and this has been a problem in the
passed on some platforms.
Your changes are sensible and this looks to merge.
Changes look sensible and good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
