[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521190#comment-16521190
]
ASF GitHub Bot commented on FLINK-6846:
---------------------------------------
Github user walterddr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r197614566
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -328,6 +330,42 @@ case class TemporalOverlaps(
}
}
+ /**
+ * Standard conversion of the TIMESTAMPADD operator.
+ * Source:
[[org.apache.calcite.sql2rel.StandardConvertletTable#TimestampAddConvertlet]]
+ */
+case class TimestampAdd(
+ unit: Expression,
+ count: Expression,
+ timestamp: Expression)
+ extends Expression {
+
+ override private[flink] def children = unit :: count :: timestamp :: Nil
+
+ override private[flink] def toRexNode(implicit relBuilder: RelBuilder) =
{
+ var timeUnit : Option[TimeUnit] = None
+ if (unit.isInstanceOf[Literal]) {
+ var unitValue= unit.asInstanceOf[Literal].value.toString()
+ val sqlTsiArray = Array("SQL_TSI_YEAR", "SQL_TSI_QUARTER",
"SQL_TSI_MONTH", "SQL_TSI_WEEK",
+ "SQL_TSI_DAY", "SQL_TSI_HOUR", "SQL_TSI_MINUTE",
"SQL_TSI_SECOND")
+ if (sqlTsiArray.contains(unitValue)) {
+ unitValue = unitValue.split("_").last
+ }
+ timeUnit = Some(TimeUnit.valueOf(unitValue))
+ }
+
+ relBuilder.call(SqlStdOperatorTable.DATETIME_PLUS, timestamp.toRexNode,
+ relBuilder.call(SqlStdOperatorTable.MULTIPLY,
+
relBuilder.getRexBuilder.makeIntervalLiteral(timeUnit.get.multiplier,
--- End diff --
I think this part can probably be further optimize if `count` is also a
Literal, this way the MULTIPLY operator is not necessary and it can directly
convert to `IntervalSqlType`. what do you think?
> Add TIMESTAMPADD supported in TableAPI
> --------------------------------------
>
> Key: FLINK-6846
> URL: https://issues.apache.org/jira/browse/FLINK-6846
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Labels: pull-request-available, starter
>
> See FLINK-6811 for detail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
