[
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521362#comment-16521362
]
ASF GitHub Bot commented on FLINK-9642:
---------------------------------------
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/6205#discussion_r197627451
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
---
@@ -75,6 +76,9 @@
private MapState<Long, Integer> eventsCount;
private MapState<NodeId, Lockable<SharedBufferNode>> entries;
+ private HashMap<EventId, Lockable<V>> eventsBufferCache = new
HashMap<>();
+ private HashMap<NodeId, Lockable<SharedBufferNode>> entryCache = new
HashMap<>();
--- End diff --
I would suggest change it to
`private Map<EventId, Lockable<V>> eventsBufferCache = new HashMap<>();`
> Reduce the count to deal with state during a CEP process
> ---------------------------------------------------------
>
> Key: FLINK-9642
> URL: https://issues.apache.org/jira/browse/FLINK-9642
> Project: Flink
> Issue Type: Improvement
> Components: CEP
> Affects Versions: 1.6.0
> Reporter: aitozi
> Assignee: aitozi
> Priority: Major
> Labels: pull-request-available
>
> With the rework of sharedBuffer Flink-9418, the lock & release operation is
> deal with rocksdb state which is different from the previous version which
> will read the state of sharedBuffer all to memory, i think we can add a cache
> or variable in sharedbuffer to cache the LockAble Object to mark the ref
> change in once process in NFA, this will reduce the count when the events
> point to the same NodeId.. And flush the result to MapState at the end of
> process.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
