[
https://issues.apache.org/jira/browse/FLINK-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522045#comment-16522045
]
ASF GitHub Bot commented on FLINK-9624:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6199#discussion_r197721680
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
---
@@ -114,17 +114,12 @@ public JarRunHandler(
CompletableFuture<JobGraph> jarUploadFuture =
jobGraphFuture.thenCombine(blobServerPortFuture, (jobGraph, blobServerPort) -> {
final InetSocketAddress address = new
InetSocketAddress(getDispatcherHost(gateway), blobServerPort);
- final List<PermanentBlobKey> keys;
- try {
- keys = BlobClient.uploadFiles(address,
configuration, jobGraph.getJobID(), jobGraph.getUserJars());
+ try (BlobClient blobClient = new BlobClient(address,
configuration)) {
+ ClientUtils.uploadAndSetUserJars(jobGraph,
blobClient);
--- End diff --
we _could_ use `uploadJobGraphFiles` here, but there isn't really a
use-case for uploading distributed cache artifacts when going through the
JarRunHandler, since we're already on the server here.
> Move jar/artifact upload logic out of JobGraph
> ----------------------------------------------
>
> Key: FLINK-9624
> URL: https://issues.apache.org/jira/browse/FLINK-9624
> Project: Flink
> Issue Type: Improvement
> Components: Job-Submission
> Affects Versions: 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The {{JobGraph}} offers utility methods for uploading jars and artifacts to
> the BlobService.
> However, how these files are uploaded isn't a concern of the {{JobGraph}} but
> the submission-method, like the {{RestClusterClient}}.
> These methods should be moved into a utility class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
