[
https://issues.apache.org/jira/browse/FLINK-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523677#comment-16523677
]
ASF GitHub Bot commented on FLINK-9634:
---------------------------------------
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/6208#discussion_r198129120
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultSlotPoolFactory.java
---
@@ -75,10 +82,21 @@ public static DefaultSlotPoolFactory fromConfiguration(
final Time rpcTimeout =
AkkaUtils.getTimeoutAsTime(configuration);
final Time slotIdleTimeout =
Time.milliseconds(configuration.getLong(JobManagerOptions.SLOT_IDLE_TIMEOUT));
+ final SchedulingStrategy schedulingStrategy =
selectSchedulingStrategy(configuration);
+
return new DefaultSlotPoolFactory(
rpcService,
+ schedulingStrategy,
SystemClock.getInstance(),
rpcTimeout,
slotIdleTimeout);
}
+
+ private static SchedulingStrategy
selectSchedulingStrategy(Configuration configuration) {
+ if
(configuration.getBoolean(CheckpointingOptions.LOCAL_RECOVERY)) {
+ return
PreviousAllocationSchedulingStrategy.getInstance();
+ } else {
+ return
LocationPreferenceSchedulingStrategy.getInstance();
--- End diff --
Does it make sense to use the `LocationPreferenceSchedulingStrategy` for
the init scheduling even when the "local recovery" is enable?
> Deactivate previous location based scheduling if local recovery is disabled
> ---------------------------------------------------------------------------
>
> Key: FLINK-9634
> URL: https://issues.apache.org/jira/browse/FLINK-9634
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0, 1.5.1
>
>
> With Flink 1.5.0 we introduced local recovery. In order to make local
> recovery work we had to change the scheduling to be aware of the previous
> location of the {{Execution}}. This scheduling strategy is also active if
> local recovery is deactivated. I suggest to also disable the scheduling
> strategy if local recovery is not enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
