[
https://issues.apache.org/jira/browse/FLINK-9665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524936#comment-16524936
]
ASF GitHub Bot commented on FLINK-9665:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6211
@lamber-ken If you are referring to the added test, it covers the case of 2
jobs (`TaskManager>>Job<<MetricGroup`) in the same registry, not TaskManagers.
There will usually not be multiple TaskManagers registered in a single
registry, but this issue applies in general to any subset of metrics with the
same logical scope.
> PrometheusReporter does not properly unregister metrics
> -------------------------------------------------------
>
> Key: FLINK-9665
> URL: https://issues.apache.org/jira/browse/FLINK-9665
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.5.0, 1.4.2, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Jelmer Kuperus
> Priority: Major
> Labels: pull-request-available
>
> The {{PrometheusReporter}} groups metrics with the same logical scope in a
> single {{Collector}} which are periodically polled by Prometheus.
> New metrics are added to an existing collector, and a reference count is
> maintained so we can eventually cleanup the {{Collector}} itself.
> For removed metrics we decrease the reference count, do not however remove
> the metrics that were added. As a result the collector will continue to
> expose metrics, as long as at least 1 metric exists with the same logical
> scope.
> If the collector is a {{io.prometheus.client.Gauge}} we can use the
> {{#remove()}} method. For histograms we will have to modify our
> {{HistogramSummaryProxy}} class to allow removing individual histograms.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
