[
https://issues.apache.org/jira/browse/FLINK-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528772#comment-16528772
]
ASF GitHub Bot commented on FLINK-9695:
---------------------------------------
GitHub user lishim opened a pull request:
https://github.com/apache/flink/pull/6232
[FLINK-9695] [mesos] Add option for Mesos executor to forcefully pull
Docker images
## What is the purpose of the change
* This pull request introduces an option for Mesos executor to forcefully
pull Docker images
## Brief change log
* A new parameter
```mesos.resourcemanager.tasks.container.docker.forcePullImage``` was introduced
## Verifying this change
This change added tests and can be verified as follows:
- Added unit tests that verify correctness of behavior of new parameter
- Manually verified behavior by running Flink in Mesos with Docker
containerizer and 2 task managers. Confirmed that when a task started on a
node where the task image already resided, an existing cached image was used
when ```mesos.resourcemanager.tasks.container.docker.forcePullImage``` was left
out or set to ```false```. Confirmed that fresh image was pulled and used over
a cached image when
```mesos.resourcemanager.tasks.container.docker.forcePullImage``` was set to
```true```.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lishim/flink feature/forcePullImage
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6232
----
commit 2e6274b1f4f3692ae4bc57780ba3c4888e7123d6
Author: Leonid Ishimnikov <lishim@...>
Date: 2018-06-30T05:34:23Z
[FLINK-9695] Added
mesos.resourcemanager.tasks.container.docker.forcePullImage option
----
> Add option for Mesos executor to forcefully pull Docker images
> --------------------------------------------------------------
>
> Key: FLINK-9695
> URL: https://issues.apache.org/jira/browse/FLINK-9695
> Project: Flink
> Issue Type: Improvement
> Components: Mesos
> Reporter: Leonid Ishimnikov
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> It would be useful to have an option to forcefully pull Docker images for
> tasks, rather than reuse a previously cached image. Such option exists in
> many Mesos frameworks, and it significantly simplifies debugging. I propose
> adding a new {{mesos.resourcemanager.tasks.container.docker.forcePullImage}}
> option.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
