[
https://issues.apache.org/jira/browse/FLINK-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648043#comment-14648043
]
ASF GitHub Bot commented on FLINK-2431:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/961
[FLINK-2431] Refactor PlanBinder/OperationInfo
PlanBinder methods were restructured to make the class more readable.
Keys are now stored as strings to simplify string-key-expression support.
Parameter retrieval was moved from PlanBinder to OperationInfo constructor,
similiar to PythonOperationInfo.
This change reduces the clutter in Planbinder and allows code re-usage for
operations with similar parameters.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 2431_pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/961.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #961
----
commit 908151add9f411309042c11091981dd577a3282d
Author: zentol <[email protected]>
Date: 2015-07-30T09:18:35Z
[FLINK-2431] Refactor PlanBinder/OperationInfo
PlanBinder methods were restructured to make the class more readable.
Keys are now stored as strings to simplify string-key-expression support.
Parameter retrieval was moved from PB to OI constructor, similiar to
PythonOperationInfo.
This change reduces the clutter in Planbinder and allows code reusage for
operations with similar parameters.
----
> [py] refactor PlanBinder/OperationInfo
> --------------------------------------
>
> Key: FLINK-2431
> URL: https://issues.apache.org/jira/browse/FLINK-2431
> Project: Flink
> Issue Type: Improvement
> Components: Python API
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
>
> These two classes deserve a restructuring to become more readable and
> consistent with PythonPlanBinder/PythonOperationInfo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
