Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6140#discussion_r199760506
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -166,6 +166,10 @@ public Configuration getConfiguration() {
                return copiedConfiguration;
        }
     
    +   public static Options getCustomCommandLineOptions() {
    --- End diff --
    
    it should be possible for this getter to be non-static. Then the changes to 
the `customCommandLineOptions` field are unnecessary, and the in `FlinkShell` 
replace `CliFrontend.getCustomCommandLineOptions()` with 
`frontend.getCustomCommandLineOptions`


---

Reply via email to