[ 
https://issues.apache.org/jira/browse/FLINK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531242#comment-16531242
 ] 

ASF GitHub Bot commented on FLINK-9091:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6102#discussion_r199776816
  
    --- Diff: tools/check_dependency_convergence.sh ---
    @@ -0,0 +1,67 @@
    +#!/usr/bin/env bash
    
+################################################################################
    +#  Licensed to the Apache Software Foundation (ASF) under one
    +#  or more contributor license agreements.  See the NOTICE file
    +#  distributed with this work for additional information
    +#  regarding copyright ownership.  The ASF licenses this file
    +#  to you under the Apache License, Version 2.0 (the
    +#  "License"); you may not use this file except in compliance
    +#  with the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +HERE="`dirname \"$0\"`"                            # relative
    +HERE="`( cd \"$HERE\" && pwd )`"   # absolutized and normalized
    +if [ -z "$HERE" ] ; then
    +   # error; for some reason, the path is not accessible
    +   # to the script (e.g. permissions re-evaled after suid)
    +   exit 1  # fail
    +fi
    +
    +FLINK_DIR=HERE
    +
    +if [[ $(basename ${HERE}) == "tools" ]] ; then
    +  FLINK_DIR="${HERE}/.."
    +fi
    +
    +FLINK_DIR="`( cd \"${FLINK_DIR}\" && pwd )`" 
    +
    +echo ${FLINK_DIR}
    +
    +# get list of all flink modules
    +# searches for directories containing a pom.xml file
    +# sorts the list alphabetically
    +# only accepts directories starting with "flink" to filter force-shading
    +modules=$(find -maxdepth 3 -name 'pom.xml' -printf '%h\n' | sort -u | grep 
"flink")
    +
    +for module in ${modules}
    +do
    +    # we are only interested in child modules
    +    for other_module in ${modules}
    +    do 
    +        if [[ "${other_module}" != "${module}" && "${other_module}" = 
"${module}"/* ]]; then
    +        echo "excluding ${module} since it is not a leaf module"
    +            continue 2
    +        fi
    +    done
    +    
    +    cd "${module}"
    +    echo "checking ${module}"
    +    output=$(mvn validate -nsu -Dcheckstyle.skip=true -Dcheck-convergence)
    --- End diff --
    
    We explicitly run `rat` in the `verify`, which is also the one `scalastyle` 
runs in by default. 


> Failure while enforcing releasability in building flink-json module
> -------------------------------------------------------------------
>
>                 Key: FLINK-9091
>                 URL: https://issues.apache.org/jira/browse/FLINK-9091
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>            Reporter: Ted Yu
>            Assignee: Hai Zhou
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: f-json.out
>
>
> Got the following when building flink-json module:
> {code}
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence 
> failed with message:
> Failed while enforcing releasability. See above detailed error message.
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce 
> (dependency-convergence) on project flink-json: Some Enforcer rules have 
> failed.   Look above for specific messages explaining why the rule failed. -> 
> [Help 1]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to