Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199781443
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverterTest.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.formats.avro.typeutils;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.formats.avro.generated.User;
+import org.apache.flink.types.Row;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Tests for {@link AvroSchemaConverter}.
+ */
+public class AvroSchemaConverterTest {
+
+ @Test
+ public void testAvroClassConversion() {
+ validateUserSchema(AvroSchemaConverter.convert(User.class));
+ }
+
+ @Test
+ public void testAvroSchemaConversion() {
+ final String schema = User.getClassSchema().toString(true);
+ validateUserSchema(AvroSchemaConverter.convert(schema));
+ }
+
+ private void validateUserSchema(TypeInformation<?> actual) {
+ final TypeInformation<Row> address = Types.ROW_NAMED(
+ new String[]{"num", "street", "city", "state", "zip"},
+ Types.INT, Types.STRING, Types.STRING, Types.STRING,
Types.STRING);
+
+ final TypeInformation<Row> user = Types.ROW_NAMED(
+ new String[] {"name", "favorite_number",
"favorite_color", "type_long_test",
--- End diff --
I would argue that in that case one entry per line is more readable. The
problem with such lines is that whenever someone modifies one entry or add an
entry in the middle, diffs are unreadable. Also any conflicts (if two commits
added an entry) with multiple entries per line are nasty, while with one entry
per line usually there are no conflicts - or they are easy to solve.
---
