Github user jamescao commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-126536010
Hi Chiwan
Thanks for your comment! I was new to this community and I am not very
familiar with the design conventions.
1. I was a little bit confused about the api structure. `TableEnvironment`
is in `org.apache.flink.api.java.table` so I guess it should be a java only
api. In that case, the scala test I uploaded is inappropriate in the first
place. If we introduce `fromCsvFile` for scala table api, it should be in
`org.apace.flink.api.scala.table.TableEnviroment`. Is this right?
2. I will work on a scala api using `readCsvFile()` instead of delegating
to the java api.
3. I will improve the test by comparing the result in memory.
4. I will make the options comply to the builder pattern.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
