[ 
https://issues.apache.org/jira/browse/FLINK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533820#comment-16533820
 ] 

ASF GitHub Bot commented on FLINK-9730:
---------------------------------------

Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6247#discussion_r200398562
  
    --- Diff: 
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
 ---
    @@ -179,7 +179,7 @@ public void close() throws Exception {
     
                @Override
                public void asyncInvoke(final Integer input, final 
ResultFuture<String> resultFuture) throws Exception {
    -                   this.executorService.submit(new Runnable() {
    +                   executorService.submit(new Runnable() {
    --- End diff --
    
    @nekrassov, right. 
    These two variables are private(`random`,`executorService`), so can remove 
static define. do you think so?


> avoid access static via class reference
> ---------------------------------------
>
>                 Key: FLINK-9730
>                 URL: https://issues.apache.org/jira/browse/FLINK-9730
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: lamber-ken
>            Assignee: lamber-ken
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> [code refactor] access static via class reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to