[
https://issues.apache.org/jira/browse/FLINK-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535745#comment-16535745
]
ASF GitHub Bot commented on FLINK-9407:
---------------------------------------
Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/6075
Hi @zhangminglei , thanks very much for your PR.
As for dependencies, I think it is better to move ORC related classes into
the module of `flink-orc`, so we don't need to add orc dependency in module of
`flink-connector-filesystem`.
Moreover, the `OrcFileWriter` should implement interface
`CheckpointedFunction` to prevent loss of data in `rowBatch` during job
failover. During checkpointing, you can store the data in `rowBatch` into
state, or call `flush()`. Similar logic can be found in `BucketingSink`.
Best, Hequn.
> Support orc rolling sink writer
> -------------------------------
>
> Key: FLINK-9407
> URL: https://issues.apache.org/jira/browse/FLINK-9407
> Project: Flink
> Issue Type: New Feature
> Components: filesystem-connector
> Reporter: zhangminglei
> Assignee: zhangminglei
> Priority: Major
> Labels: patch-available, pull-request-available
>
> Currently, we only support {{StringWriter}}, {{SequenceFileWriter}} and
> {{AvroKeyValueSinkWriter}}. I would suggest add an orc writer for rolling
> sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
